-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-14347][PM-14348] New Device Verification Logic #12451
base: PM-8214-new-device-notice-UI
Are you sure you want to change the base?
[PM-14347][PM-14348] New Device Verification Logic #12451
Conversation
…PI multiple times
…warden/clients into vault/pm-14347/device-vertification-logic
- remove remind me later link for permanent logic
…warden/clients into vault/pm-14347/device-vertification-logic
… API directly. The API for 2FA providers is only available on web so it didn't work for browser & native.
…warden/clients into vault/pm-14347/device-vertification-logic
- profile creation is used from other sources
Fixed Issues
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## PM-8214-new-device-notice-UI #12451 +/- ##
================================================================
+ Coverage 33.50% 33.62% +0.11%
================================================================
Files 2921 2920 -1
Lines 91229 91267 +38
Branches 17358 17366 +8
================================================================
+ Hits 30570 30689 +119
+ Misses 58251 58160 -91
- Partials 2408 2418 +10 ☔ View full report in Codecov by Sentry. |
…warden/clients into vault/pm-14347/device-vertification-logic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good! Just noticed one issue with regards to the active userId and caching the profile.
Also, thanks for all the tests!! 🧪 🎉
…warden/clients into vault/pm-14347/device-vertification-logic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Nice work!
🎟️ Tracking
PM-14347
PM-14348
📔 Objective
Stacked on top of @Jingo88's PR: #12360
Adds logic for new device verification pages, guards and state
📸 Screenshots
new-device-temporary.mov
new-device-permanent.mov
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes