Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-14347][PM-14348] New Device Verification Logic #12451

Open
wants to merge 20 commits into
base: PM-8214-new-device-notice-UI
Choose a base branch
from

Conversation

nick-livefront
Copy link
Collaborator

@nick-livefront nick-livefront commented Dec 17, 2024

🎟️ Tracking

PM-14347
PM-14348

📔 Objective

Stacked on top of @Jingo88's PR: #12360

Adds logic for new device verification pages, guards and state

  • Adds check for scenarios when the new device verification is hidden
  • Adds logic for temporary flag which will be shown every 7 days until the user enables 2 factor auth
  • Adds logic for permanent flag which is blocking until the user enables two factor auth or selects they have reliable access.
  • Adds missing question mark to "access to email" copy

📸 Screenshots

Temporary Permanent
new-device-temporary.mov
new-device-permanent.mov

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@nick-livefront nick-livefront requested a review from a team as a code owner December 17, 2024 21:04
Copy link
Contributor

github-actions bot commented Dec 17, 2024

Logo
Checkmarx One – Scan Summary & Details15a9fb73-9ce2-4181-939a-625e9691658b

Fixed Issues

Severity Issue Source File / Package
LOW Client_JQuery_Deprecated_Symbols /apps/cli/src/service-container/service-container.ts: 878

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 96.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 33.62%. Comparing base (2ac259d) to head (10665e4).

Files with missing lines Patch % Lines
...ult/guards/new-device-verification-notice.guard.ts 91.17% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@                       Coverage Diff                        @@
##           PM-8214-new-device-notice-UI   #12451      +/-   ##
================================================================
+ Coverage                         33.50%   33.62%   +0.11%     
================================================================
  Files                              2921     2920       -1     
  Lines                             91229    91267      +38     
  Branches                          17358    17366       +8     
================================================================
+ Hits                              30570    30689     +119     
+ Misses                            58251    58160      -91     
- Partials                           2408     2418      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@shane-melton shane-melton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good! Just noticed one issue with regards to the active userId and caching the profile.

Also, thanks for all the tests!! 🧪 🎉

Copy link
Member

@shane-melton shane-melton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants