[PM-16194] Do not sort Favorite ciphers by last used date #12466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shane-melton
commented
Dec 18, 2024
| */ | ||
| favoriteCiphers$: Observable<PopupCipherView[]> = this.autoFillCiphers$.pipe( | ||
| withLatestFrom(this._filteredCipherList$), | ||
| map(([autoFillCiphers, ciphers]) => | ||
| ciphers.filter((cipher) => cipher.favorite && !autoFillCiphers.includes(cipher)), | ||
| ), | ||
| map((ciphers) => |
There was a problem hiding this comment.
ℹ️ The ciphers are already sorted by name via the CipherService.cipherView$ observable and do not need to be sorted again now that we are not sorting by last used.
|
New Issues
Fixed Issues
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12466 +/- ##
==========================================
- Coverage 33.52% 33.49% -0.03%
==========================================
Files 2913 2917 +4
Lines 91086 91162 +76
Branches 17338 17348 +10
==========================================
+ Hits 30533 30534 +1
- Misses 58146 58228 +82
+ Partials 2407 2400 -7 ☔ View full report in Codecov by Sentry. |
merissaacosta
approved these changes
Dec 18, 2024
nick-livefront
approved these changes
Dec 18, 2024
|
@shane-melton, why? I rather like this new sort method. Couldn't you just let us change the sorting method? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-16194
📔 Objective
Revert the change to favorite item sorting so that favorite items are once again only sorted alphabetically by name.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes