Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-15637] Configure deepLinkGuard in OrganizationsModule for Device Approval Links #12890

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

r-tome
Copy link
Contributor

@r-tome r-tome commented Jan 15, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-15637

📔 Objective

This PR adds deepLinkGuard to the OrganizationsModule to enable deep linking for device approval email notification links. This ensures users can directly navigate to the appropriate page when clicking on the links from their email notifications.

Server PR.

📸 Screenshots

Screen.Recording.2025-01-15.at.15.50.08.mov

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Jan 15, 2025

Logo
Checkmarx One – Scan Summary & Details04e13744-976f-4b73-9af5-105e0d169bb4

Great job, no security vulnerabilities found in this Pull Request

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 34.37%. Comparing base (58bd44f) to head (cfa748a).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...sole/organizations/organizations-routing.module.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12890   +/-   ##
=======================================
  Coverage   34.37%   34.37%           
=======================================
  Files        2952     2952           
  Lines       90448    90449    +1     
  Branches    16974    16974           
=======================================
+ Hits        31088    31095    +7     
+ Misses      56896    56890    -6     
  Partials     2464     2464           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@r-tome r-tome marked this pull request as ready for review January 15, 2025 17:36
@r-tome r-tome requested a review from a team as a code owner January 15, 2025 17:36
@r-tome r-tome requested a review from BTreston January 15, 2025 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants