Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-16702] Adding break-words to imported filename #12915

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MarsCandyBars
Copy link

@MarsCandyBars MarsCandyBars commented Jan 16, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-16702

📔 Objective

When importing a file, if the file name is long and without any spaces, the file name will overflow the div/viewport and looks less refined. This PR adds the break-words class to prevent the overflow in all clients, though the issue is much less noticeable in web in general due to the typically larger viewport.

📸 Screenshots

Before:

image

After:

image

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@MarsCandyBars MarsCandyBars requested a review from a team as a code owner January 16, 2025 17:39
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details0ae8ec2c-0fee-45aa-a3d2-6f4e5d15c87b

Great job, no security vulnerabilities found in this Pull Request

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.44%. Comparing base (e815f89) to head (18d44e8).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12915   +/-   ##
=======================================
  Coverage   34.44%   34.44%           
=======================================
  Files        2974     2974           
  Lines       90667    90667           
  Branches    16989    16989           
=======================================
  Hits        31233    31233           
  Misses      56968    56968           
  Partials     2466     2466           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@djsmith85 djsmith85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MarsCandyBars Awesome, thank you for providing a fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants