Auth/PM-17197 - UnauthGuard Trusted Devices Lock State Refactor

[JaredSnider-Bitwarden]

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-17197

📔 Objective

To make the unauthGuard aware of the Trusted Device Encryption lock state so that, in specific situations where you refresh on an unauthenticated screen in the sidebar of Firefox or other browsers with sidebars after completing authentication in the extension popout, the sidebar can refresh and take you to the login initiated screen appropriately. Previously, the unauthGuard would send the user to the lock screen and the lockGuard would deny navigation so the user would be left on a blank screen in the sidebar.

📸 Screenshots

Firefox.SSO.+.2FA.+.TDE.+.Sidebar.Working.mov

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[codecov]

Codecov Report

Attention: Patch coverage is 85.71429% with 4 lines in your changes missing coverage. Please review.

Project coverage is 34.33%. Comparing base (ce2ec07) to head (b201f57).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
libs/angular/src/auth/guards/unauth.guard.ts	92.00%	1 Missing and 1 partial ⚠️
...th/services/device-trust.service.implementation.ts	33.33%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #12938      +/-   ##
==========================================
+ Coverage   34.32%   34.33%   +0.01%     
==========================================
  Files        2976     2976              
  Lines       90551    90569      +18     
  Branches    16959    16963       +4     
==========================================
+ Hits        31079    31101      +22     
+ Misses      57015    57009       -6     
- Partials     2457     2459       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Checkmarx One – Scan Summary & Details – 8e231e7e-8760-4bc7-a73e-cad718bb1d06

Great job, no security vulnerabilities found in this Pull Request