Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BRE-714] Enhance TestFlight desktop publishing #13871

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

michalchecinski
Copy link
Contributor

@michalchecinski michalchecinski commented Mar 17, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/BRE-714

📔 Objective

  • Change Test Flight desktop publishing method to fastlane
  • Add input to release to TestFlight from a feature branch even if main, rc or hotfix-rc-desktop branch exists.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Verified

This commit was signed with the committer’s verified signature.
michalchecinski Michał Chęciński

Verified

This commit was signed with the committer’s verified signature.
michalchecinski Michał Chęciński
Fix

Verified

This commit was signed with the committer’s verified signature.
michalchecinski Michał Chęciński

Verified

This commit was signed with the committer’s verified signature.
michalchecinski Michał Chęciński

Verified

This commit was signed with the committer’s verified signature.
michalchecinski Michał Chęciński

Verified

This commit was signed with the committer’s verified signature.
michalchecinski Michał Chęciński

Verified

This commit was signed with the committer’s verified signature.
michalchecinski Michał Chęciński

Verified

This commit was signed with the committer’s verified signature.
michalchecinski Michał Chęciński

Verified

This commit was signed with the committer’s verified signature.
michalchecinski Michał Chęciński

Verified

This commit was signed with the committer’s verified signature.
michalchecinski Michał Chęciński

Verified

This commit was signed with the committer’s verified signature.
michalchecinski Michał Chęciński
@michalchecinski michalchecinski requested a review from a team March 17, 2025 13:38
@michalchecinski michalchecinski requested a review from a team as a code owner March 17, 2025 13:38
Copy link

codecov bot commented Mar 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.39%. Comparing base (ec488e4) to head (4567667).
Report is 162 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13871      +/-   ##
==========================================
+ Coverage   35.80%   36.39%   +0.58%     
==========================================
  Files        3172     3173       +1     
  Lines       93596    92327    -1269     
  Branches    17019    16719     -300     
==========================================
+ Hits        33515    33603      +88     
+ Misses      57490    56134    -1356     
+ Partials     2591     2590       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

github-actions bot commented Mar 17, 2025

Logo
Checkmarx One – Scan Summary & Details1c9b4614-7fa5-40f8-893e-5d58e17a601f

Great job, no security vulnerabilities found in this Pull Request

mimartin12
mimartin12 previously approved these changes Mar 17, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Co-authored-by: MtnBurrit0 <77340197+mimartin12@users.noreply.github.com>
mimartin12
mimartin12 previously approved these changes Mar 18, 2025
addisonbeck
addisonbeck previously approved these changes Mar 18, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants