-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-10610] push notification to end user notification service #13876
base: main
Are you sure you want to change the base?
[PM-10610] push notification to end user notification service #13876
Conversation
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #13876 +/- ##
=======================================
Coverage 36.34% 36.34%
=======================================
Files 3180 3180
Lines 92462 92471 +9
Branches 16747 16749 +2
=======================================
+ Hits 33603 33608 +5
- Misses 56269 56272 +3
- Partials 2590 2591 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Great job, no security vulnerabilities found in this Pull Request |
|
🎟️ Tracking
PM-10610
📔 Objective
Inside the
default end user notification service
use thenotifications$
observable inside thedefault-notifications service
to update state whenever aNotificationType === Notification || NotificationStatus
is called.⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes