-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-19240] Do not show task unless Manage or Edit Permission #13880
Conversation
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #13880 +/- ##
==========================================
- Coverage 36.29% 36.29% -0.01%
==========================================
Files 3182 3182
Lines 92605 92609 +4
Branches 16784 16786 +2
==========================================
+ Hits 33612 33613 +1
- Misses 56401 56403 +2
- Partials 2592 2593 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Great job, no security vulnerabilities found in this Pull Request |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We just need to address Nick's comment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Auth changes look good.
🎟️ Tracking
PM-19240
📔 Objective
Security Task should only show for
Manage
andEdit
permissions. It should not show forEdit Except Password
.The display requirements does not change when a collection has the
Manage All
settings flag turned on📸 Screen Recording
PM-19240-edit-except-pw-task-hide.mov
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes