Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-19240] Do not show task unless Manage or Edit Permission #13880

Merged
merged 3 commits into from
Mar 20, 2025

Conversation

Jingo88
Copy link
Contributor

@Jingo88 Jingo88 commented Mar 18, 2025

🎟️ Tracking

PM-19240

📔 Objective

Security Task should only show for Manage and Edit permissions. It should not show for Edit Except Password.
The display requirements does not change when a collection has the Manage All settings flag turned on

📸 Screen Recording

PM-19240-edit-except-pw-task-hide.mov

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

codecov bot commented Mar 18, 2025

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 36.29%. Comparing base (45d5b17) to head (d95ed39).
Report is 6 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ibs/vault/src/cipher-view/cipher-view.component.ts 20.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13880      +/-   ##
==========================================
- Coverage   36.29%   36.29%   -0.01%     
==========================================
  Files        3182     3182              
  Lines       92605    92609       +4     
  Branches    16784    16786       +2     
==========================================
+ Hits        33612    33613       +1     
- Misses      56401    56403       +2     
- Partials     2592     2593       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

github-actions bot commented Mar 18, 2025

Logo
Checkmarx One – Scan Summary & Details6fa92c4f-be8c-41e7-b21c-adba1fa3f8e9

Great job, no security vulnerabilities found in this Pull Request

@Jingo88 Jingo88 requested review from shane-melton, gbubemismith and nick-livefront and removed request for vincentsalucci March 18, 2025 15:38
nick-livefront
nick-livefront previously approved these changes Mar 19, 2025
Copy link
Member

@shane-melton shane-melton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We just need to address Nick's comment

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Auth changes look good.

@Jingo88 Jingo88 merged commit cf82798 into main Mar 20, 2025
98 checks passed
@Jingo88 Jingo88 deleted the PM-19240-task-edit-except-pw branch March 20, 2025 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants