Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate the remaining Auth Request methods in AuthRequestApiService #13890

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

trmartin4
Copy link
Member

@trmartin4 trmartin4 commented Mar 18, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-3519

📔 Objective

Moved the remaining methods from the ApiService to the AuthRequestApiService, which was created as part of #11545.

📸 Screenshots

Admin approval

admin_auth_request_approval.mov

TDE approval from another device

Login with Device

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

codecov bot commented Mar 18, 2025

Codecov Report

Attention: Patch coverage is 70.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 36.42%. Comparing base (e8c4c57) to head (a659544).
Report is 10 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...auth/models/request/auth-request-update.request.ts 20.00% 4 Missing ⚠️
...pps/desktop/src/vault/app/vault/vault.component.ts 0.00% 3 Missing ⚠️
apps/browser/src/background/main.background.ts 0.00% 1 Missing ⚠️
...angular/login-approval/login-approval.component.ts 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13890      +/-   ##
==========================================
+ Coverage   36.39%   36.42%   +0.03%     
==========================================
  Files        3174     3173       -1     
  Lines       92350    92328      -22     
  Branches    16727    16719       -8     
==========================================
+ Hits        33610    33634      +24     
+ Misses      56146    56104      -42     
+ Partials     2594     2590       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

github-actions bot commented Mar 18, 2025

Logo
Checkmarx One – Scan Summary & Detailsf8a355a3-3306-4d04-8fa8-0da6b30e207d

Great job, no security vulnerabilities found in this Pull Request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant