Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When vault is locked also check for personal ownership policy #2153

Merged
merged 2 commits into from
Nov 2, 2021

Conversation

djsmith85
Copy link
Contributor

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

If the vault is locked and a user tries to log-in to a new site, we will check for the DisablePersonalOwnership policy (no private vault) and not show the prompt if it is active. This is to ensure the same behaviour as if the vault was unlocked.

In the future we will want to enable users with this policy active to save new credentials to an Org and/or collection. For now though, this fix prevents users from saving new logins in a vault they shouldn't have.

Asana ticket: https://app.asana.com/0/1200804338582616/1201295056358742/f

Code changes

  • src/background/notification.background.ts: Added the same check for allowPersonalOwnership if the vault is locked

Testing requirements

All users of an organizations that have the DisablePersonalOwernship policy active, should not be shown a prompt to save new logins.

Before you submit

  • I have checked for linting errors (npm run lint) (required)
  • This change requires a documentation update (notify the documentation team) - Done in parent Asana ticket : https://app.asana.com/0/0/1201284867742659/f
  • This change has particular deployment requirements (notify the DevOps team)

src/background/notification.background.ts Outdated Show resolved Hide resolved
@djsmith85 djsmith85 requested a review from eliykat November 2, 2021 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants