-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Key Connector] Add support for key connector and OTP #2156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en/browser into feature/crypto-agent-otp
…ature/crypto-agent-otp # Conflicts: # src/background/main.background.ts
eliykat
changed the title
Add support for crypto-agent OTP
[Key Connector] Add support for key connector and OTP
Nov 8, 2021
eliykat
commented
Nov 8, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Hinton a couple of comments below. Nice solution to the 'state' problem I think.
- Did you mean to bump jslib on this branch before the jslib PR is merged?
addisonbeck
approved these changes
Nov 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
Add support for user verification using OTP instead of master password. Required to support the crypto agent.
Equivalent changes in web for reference: bitwarden/web#1256.
Code changes
onSuccessfulLogin
callback runs after the user successfully authenticates with SSO. Currently, this refreshes all open tabs/windows belonging to the extension - I'm not sure why, but I assume it's so that it'll display the unlock page properly. With Key Connector, the user is already unlocked and all this does is dump the keys out of memory, locking the vault again. So: don't refresh if the vault is already unlocked.remove-password.component
.convertAccountToKeyConnector
message sent by syncService. However, sync occurs in the background, so we need some way to persist this message when the user opens the popup. We do this by saving to storageService and checking for it in theCanActivate
guard (which is in the jslib PR). If it's detected byCanActivate
, then the user is taken to the remove password component.Screenshots
@Hinton can you please provide?
Testing requirements
General testing requirements for crypto-agent changes to be provided to QA.
Before you submit
npm run lint
) (required)