Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CL-155] Add support for hiding the close button on banner #7142

Merged
merged 1 commit into from
Dec 8, 2023
Merged

[CL-155] Add support for hiding the close button on banner #7142

merged 1 commit into from
Dec 8, 2023

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Dec 8, 2023

Type of change

- [ ] Bug fix
- [x] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Add support for. hiding the close button on banners

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team
  • Ensure that all UI additions follow WCAG AA requirements

@Hinton Hinton requested a review from a team as a code owner December 8, 2023 12:38
@github-actions github-actions bot added the needs-qa Marks a PR as requiring QA approval label Dec 8, 2023
@bitwarden-bot
Copy link

Logo
Checkmarx One – Scan Summary & Details – 37de200f-e920-48ba-be34-8ae938129e58

No New Or Fixed Issues Found

willmartian
willmartian approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@willmartian willmartian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Hinton Hinton merged commit 5a3ac7d into master Dec 8, 2023
61 checks passed
@Hinton Hinton deleted the ps/CL-155 branch December 8, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willmartian willmartian willmartian approved these changes

Assignees
No one assigned
Labels
needs-qa Marks a PR as requiring QA approval
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Hinton @bitwarden-bot @willmartian