Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ps/pm-8197/clean-up-desktop-biometric-ipc #9275

Merged
merged 3 commits into from
May 20, 2024
Merged

Ps/pm-8197/clean-up-desktop-biometric-ipc #9275

merged 3 commits into from
May 20, 2024

Conversation

MGibson1
Copy link
Member

Type of change

- [x] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Removes two bugs

  1. Browser -> Desktop biometrics integration can occasionally remove desktop biometric keys upon successful login. This was occuring due to migration code triggering a failed validation of the current user if the requested biometric key was for a non-active user.
  2. Desktop was triggering a process reload due to messaging "locked" when account switching to a locked account. this isn't necessary since the account isn't newly locked, we just have to navigate to the lock screen and close modals.

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team
  • Ensure that all UI additions follow WCAG AA requirements

@MGibson1 MGibson1 requested a review from a team as a code owner May 20, 2024 18:42
@MGibson1 MGibson1 requested a review from coroiu May 20, 2024 18:42
@github-actions github-actions bot added the needs-qa Marks a PR as requiring QA approval label May 20, 2024
justindbaur
justindbaur previously approved these changes May 20, 2024
View reviewed changes
@codecov Codecov
Copy link

codecov bot commented May 20, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 28.02%. Comparing base (6fd81fa) to head (bbdaa6e).

Files Patch % Lines
...ibs/common/src/platform/services/crypto.service.ts 0.00% 4 Missing ⚠️
apps/desktop/src/app/app.component.ts 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #9275      +/-   ##
==========================================
- Coverage   28.02%   28.02%   -0.01%     
==========================================
  Files        2360     2360              
  Lines       69779    69781       +2     
  Branches    13125    13126       +1     
==========================================
  Hits        19557    19557              
- Misses      48674    48676       +2     
  Partials     1548     1548

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MGibson1 MGibson1 requested a review from justindbaur May 20, 2024 18:51
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 20, 2024 •
edited
Loading

Logo
Checkmarx One – Scan Summary & Details – c4255362-d9b6-4d56-ae0f-97ee6e438dfe

No New Or Fixed Issues Found

@MGibson1 MGibson1 removed the needs-qa Marks a PR as requiring QA approval label May 20, 2024
@MGibson1 MGibson1 merged commit f2d24e0 into main May 20, 2024
61 of 63 checks passed
@MGibson1 MGibson1 deleted the ps/pm-8197/clean-up-desktop-biometric-ipc branch May 20, 2024 20:19
MGibson1 added a commit that referenced this pull request May 20, 2024
@MGibson1
Ps/pm-8197/clean-up-desktop-biometric-ipc (#9275)
a22d83f 
* Do not process reload on account switch

* Validate specified key against specified user

* Grab userId immediately for user key retrieval

(cherry picked from commit f2d24e0)
quexten pushed a commit that referenced this pull request May 22, 2024
@MGibson1 @quexten
Ps/pm-8197/clean-up-desktop-biometric-ipc (#9275)
027f09e 
* Do not process reload on account switch

* Validate specified key against specified user

* Grab userId immediately for user key retrieval
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justindbaur justindbaur justindbaur approved these changes

@coroiu coroiu Awaiting requested review from coroiu coroiu is a code owner automatically assigned from bitwarden/team-platform-dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MGibson1 @justindbaur