Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PS-1239] If a group name is too long, shorten it to 100 characters #277

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

hajekj
Copy link
Contributor

@hajekj hajekj commented Jul 13, 2022

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

When a group originating from Azure AD has more than 100 characters in its name, the entire import will fail. This PR shortens every group name to the maximum of 100 characters to make sure the import passes.

Code changes

Testing requirements

N/A, bugfix.

Before you submit

  • I have checked for linting errors (npm run lint) (required)
  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

@hajekj
Copy link
Contributor Author

hajekj commented Aug 3, 2022

@vgrassia could somebody look into this PR please?

@djsmith85 djsmith85 changed the title If a group name is too long, shorten it to 100 characters [PS-1239] If a group name is too long, shorten it to 100 characters Aug 3, 2022
@dbosompem
Copy link

Hi @hajekj , thank you for opening this PR. This has been added to our internal board for review. We'd get back to you with our feedback and/or concerns. Very appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants