Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BRE-30] PR Version labels #284

Merged
merged 2 commits into from
Jun 6, 2024
Merged

Conversation

michalchecinski
Copy link
Contributor

@michalchecinski michalchecinski commented May 22, 2024

๐ŸŽŸ๏ธ Tracking

https://bitwarden.atlassian.net/browse/BRE-30

๐Ÿšง Type of change

  • ๐Ÿš€ New feature development
  • ๐Ÿค– Build/deploy pipeline (DevOps)

๐Ÿ“” Objective

Create a reusable workflow to compute next version number based on label on PR: version:major, version:minor, version:patch, version:skip. Create a pr labels workflow that checks if a version label is not provided on the PR, the PR is blocked from being merged.

๐Ÿ“‹ Code changes

  • .github/workflows/_version.yml: Add reusable workflow to compute next version from PR label.
  • .github/workflows/_enforce-labels.yml Add reusable workflow for blocking a PR merge if required labels are absent or if labels that block merge are present.

๐Ÿ“ธ Screenshots

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

@michalchecinski michalchecinski requested a review from a team as a code owner May 22, 2024 13:36
@bitwarden-bot
Copy link

bitwarden-bot commented May 22, 2024

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ d77bdd84-b92b-4290-be1c-1ed47cf58030

No New Or Fixed Issues Found

@michalchecinski michalchecinski merged commit 60e6af5 into main Jun 6, 2024
3 checks passed
@michalchecinski michalchecinski deleted the BRE-30-PR-version-labels branch June 6, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants