Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BRE-425] replacing ubuntu-latest with ubuntu-24.04 #353

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

AmyLGalles
Copy link
Contributor

๐ŸŽŸ๏ธ Tracking

https://bitwarden.atlassian.net/jira/software/projects/BRE/boards/144?assignee=712020%3Aac9853d4-55a2-4808-acad-e7b7914eac07&selectedIssue=BRE-425

๐Ÿ“” Objective

Removing references to ubuntu-latest ahead of an automatic update laster this week

๐Ÿ“ธ Screenshots

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

@AmyLGalles AmyLGalles requested a review from a team as a code owner December 2, 2024 21:26
Copy link

github-actions bot commented Dec 2, 2024

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ f7cc9407-d2cb-47e4-a9b8-e43aaeb7aa1c

No New Or Fixed Issues Found

@AmyLGalles AmyLGalles merged commit ced3228 into main Dec 3, 2024
5 checks passed
@AmyLGalles AmyLGalles deleted the agalles/remove-ubuntu-latest branch December 3, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants