[PM-5832] Use package name for autofill when website is not set #2950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution! We've added this to our internal Community PR board for review. |
bitwarden-bot
mannequin
changed the title
|
No New Or Fixed Issues Found |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
When an app presents a webview, Bitwarden will populate
Websitewith the webview's url. BecauseWebsiteis not null,PackageNamewill not be assigned. If the app is not on Bitwarden's built-in browsers list,Websitewill be unassigned after that, effectively rendering autofill unusable.This PR swaps the two blocks so that package name will be assigned and autofill will be offered.
Code changes
Screenshots
Before you submit
dotnet format --verify-no-changes) (required)