Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E-Mail settings for self-hosting #712

Closed
ellwoodb opened this issue Aug 30, 2024 · 4 comments · Fixed by #724 or #725
Closed

E-Mail settings for self-hosting #712

ellwoodb opened this issue Aug 30, 2024 · 4 comments · Fixed by #724 or #725

Comments

@ellwoodb
Copy link

In a recent commit, it seems the ability to change the mailing settings via environment variables for the docker container when self hosting were removed.
I was just trying to run the container (tried both, building from source and the image on docker hub) and it doesn't take the mail settings, so it logs all mails to mails.md.
Is there a way to bring this feature back for those of us self hosting this?

@ellwoodb
Copy link
Author

The commit was the merge of pr #707

@jonashendrickx
Copy link
Member

jonashendrickx commented Sep 3, 2024

Hi @ellwoodb , check the documentation now.

It should only take very little time to update your configuration.

I believe you may be updating using the latest tag, instead of stable. Consider sticking to stable.
The latest tag could contain images that are still in QA, I hadn't published the documentation yet.

@ellwoodb
Copy link
Author

ellwoodb commented Sep 3, 2024

Hey @jonashendrickx, thank you very much! With the new variables it‘s working nicely. I‘ll close this issue now.

Yes, I was using the latest tag and now switched to stable thanks for clarifying.

Maybe, if you have time you could update the settings.env in the self-host directory to reflect the changes. I could also do that myself with a pr if that‘s allowed?

@jonashendrickx
Copy link
Member

jonashendrickx commented Sep 3, 2024

Hey @jonashendrickx, thank you very much! With the new variables it‘s working nicely. I‘ll close this issue now.

Yes, I was using the latest tag and now switched to stable thanks for clarifying.

Maybe, if you have time you could update the settings.env in the self-host directory to reflect the changes. I could also do that myself with a pr if that‘s allowed?

There's no need! Thank you!

I've opened #724 to prevent this from happening again in the future. If I pull a docker image with the latest tag, I would assume it sort of to be production ready.

I've also clarified that this is a breaking change in the release notes.

Feel free to always make a PR. We're always open!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants