Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images in QA or main should not have latest tag. #724

Merged
merged 2 commits into from
Sep 3, 2024

Conversation

jonashendrickx
Copy link
Member

@jonashendrickx jonashendrickx commented Sep 3, 2024

Ticket

Description

When we pull Docker images, we would expect to have latest always reflect a stable release or production release by default. Now, the latest tag seems to pull any image that is in the main branch or in QA testing.

I've changed the behavior to below, so people can still continue testing the latest qa or dev build separately. While the latest production release will carry the tags latest and stable in addition to their respective build numbers.

  • push to main -> dev
  • prerelease release -> qa
  • release -> latest & stable

Shape

Screenshots

Checklist

I did the following to ensure that my changes were tested thoroughly:

  • __

I did the following to ensure that my changes do not introduce security vulnerabilities:

  • __

@jonashendrickx jonashendrickx requested a review from a team as a code owner September 3, 2024 06:27
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.15%. Comparing base (2d9dd79) to head (b00c5eb).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #724   +/-   ##
=======================================
  Coverage   35.15%   35.15%           
=======================================
  Files         573      573           
  Lines       31174    31174           
  Branches      931      931           
=======================================
  Hits        10960    10960           
  Misses      20068    20068           
  Partials      146      146           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonashendrickx jonashendrickx merged commit e279fcf into main Sep 3, 2024
17 checks passed
@jonashendrickx jonashendrickx deleted the fix-images-being-published branch September 3, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

E-Mail settings for self-hosting
2 participants