Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#731 | TimeToLive is not an obsolete property #738

Merged
merged 2 commits into from
Sep 18, 2024
Merged

Conversation

jonashendrickx
Copy link
Member

@jonashendrickx jonashendrickx commented Sep 17, 2024

Ticket

Description

This is not an obsolete property as it's actually being used. This will incorrectly hide it from our Open API documentation.

Shape

Screenshots

Checklist

I did the following to ensure that my changes were tested thoroughly:

  • __

I did the following to ensure that my changes do not introduce security vulnerabilities:

  • __

@jonashendrickx jonashendrickx requested a review from a team as a code owner September 17, 2024 23:11
@jonashendrickx jonashendrickx merged commit 724c4bd into main Sep 18, 2024
16 checks passed
@jonashendrickx jonashendrickx deleted the feature/gh-731 branch September 18, 2024 11:32
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.15%. Comparing base (a5d4776) to head (ff24d6f).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #738   +/-   ##
=======================================
  Coverage   35.15%   35.15%           
=======================================
  Files         579      579           
  Lines       31252    31252           
  Branches      949      949           
=======================================
  Hits        10988    10988           
  Misses      20119    20119           
  Partials      145      145           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants