[PM-25657] Add missing SSH key and permissions fields to cipher conversion (#434)

## 🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-25657
<!-- Paste the link to the Jira or GitHub issue or otherwise describe /
point to where this change is coming from. -->

## 📔 Objective

<!-- Describe what the purpose of this PR is, for example what bug
you're fixing or new feature you're adding. -->

## ⏰ Reminders before review

- Contributor guidelines followed
- All formatters and local linters executed and passed
- Written new unit and / or integration tests where applicable
- Protected functional changes with optionality (feature flags)
- Used internationalization (i18n) for all UI strings
- CI builds passed
- Communicated to DevOps any deployment requirements
- Updated any necessary documentation (Confluence, contributing docs) or
informed the documentation
  team

## 🦮 Reviewer guidelines

<!-- Suggested interactions but feel free to use (or not) as you desire!
-->

- 👍 (`:+1:`) or similar for great changes
- 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info
- ❓ (`:question:`) for questions
- 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry
that's not quite a confirmed
  issue and could potentially benefit from discussion
- 🎨 (`:art:`) for suggestions / improvements
- ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or
concerns needing attention
- 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or
indications of technical debt
- ⛏ (`:pick:`) for minor or nitpick changes

Author: gbubemismith

crates/bitwarden-vault/src/cipher/cipher.rs

@@ -736,17 +736,15 @@ impl TryFrom<CipherDetailsResponseModel> for Cipher {
             identity: cipher.identity.map(|i| (*i).try_into()).transpose()?,
             card: cipher.card.map(|c| (*c).try_into()).transpose()?,
             secure_note: cipher.secure_note.map(|s| (*s).try_into()).transpose()?,
-            // TODO: add ssh_key when api bindings have been updated
-            ssh_key: None,
+            ssh_key: cipher.ssh_key.map(|s| (*s).try_into()).transpose()?,
             favorite: cipher.favorite.unwrap_or(false),
             reprompt: cipher
                 .reprompt
                 .map(|r| r.into())
                 .unwrap_or(CipherRepromptType::None),
             organization_use_totp: cipher.organization_use_totp.unwrap_or(true),
             edit: cipher.edit.unwrap_or(true),
-            // TODO: add permissions when api bindings have been updated
-            permissions: None,
+            permissions: cipher.permissions.map(|p| (*p).try_into()).transpose()?,
             view_password: cipher.view_password.unwrap_or(true),
             local_data: None, // Not sent from server
             attachments: cipher

crates/bitwarden-vault/src/cipher/cipher_permissions.rs

@@ -1,7 +1,11 @@
+use bitwarden_api_api::models::CipherPermissionsResponseModel;
+use bitwarden_core::require;
 use serde::{Deserialize, Serialize};
 #[cfg(feature = "wasm")]
 use tsify::Tsify;
 
+use crate::VaultParseError;
+
 #[derive(Serialize, Copy, Deserialize, Debug, Clone, PartialEq)]
 #[serde(rename_all = "camelCase", deny_unknown_fields)]
 #[cfg_attr(feature = "uniffi", derive(uniffi::Record))]
@@ -10,3 +14,14 @@ pub struct CipherPermissions {
     pub delete: bool,
     pub restore: bool,
 }
+
+impl TryFrom<CipherPermissionsResponseModel> for CipherPermissions {
+    type Error = VaultParseError;
+
+    fn try_from(permissions: CipherPermissionsResponseModel) -> Result<Self, Self::Error> {
+        Ok(Self {
+            delete: require!(permissions.delete),
+            restore: require!(permissions.restore),
+        })
+    }
+}

crates/bitwarden-vault/src/cipher/ssh_key.rs

@@ -1,4 +1,8 @@
-use bitwarden_core::key_management::{KeyIds, SymmetricKeyId};
+use bitwarden_api_api::models::CipherSshKeyModel;
+use bitwarden_core::{
+    key_management::{KeyIds, SymmetricKeyId},
+    require,
+};
 use bitwarden_crypto::{
     CompositeEncryptable, CryptoError, Decryptable, EncString, KeyStoreContext,
     PrimitiveEncryptable,
@@ -8,7 +12,7 @@ use serde::{Deserialize, Serialize};
 use tsify::Tsify;
 
 use super::cipher::CipherKind;
-use crate::{cipher::cipher::CopyableCipherFields, Cipher};
+use crate::{cipher::cipher::CopyableCipherFields, Cipher, VaultParseError};
 
 #[derive(Serialize, Deserialize, Debug, Clone)]
 #[serde(rename_all = "camelCase", deny_unknown_fields)]
@@ -79,6 +83,18 @@ impl CipherKind for SshKey {
     }
 }
 
+impl TryFrom<CipherSshKeyModel> for SshKey {
+    type Error = VaultParseError;
+
+    fn try_from(ssh_key: CipherSshKeyModel) -> Result<Self, Self::Error> {
+        Ok(Self {
+            private_key: require!(EncString::try_from_optional(ssh_key.private_key)?),
+            public_key: require!(EncString::try_from_optional(ssh_key.public_key)?),
+            fingerprint: require!(EncString::try_from_optional(ssh_key.key_fingerprint)?),
+        })
+    }
+}
+
 #[cfg(test)]
 mod tests {
     use bitwarden_core::key_management::create_test_crypto_with_user_key;