Skip to content

Conversation

gbubemismith
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-25657

📔 Objective

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details289ffca1-ce95-482a-8176-3e0a5a98ba64

Great job! No new security vulnerabilities introduced in this pull request

Copy link

Copy link

codecov bot commented Sep 10, 2025

Codecov Report

❌ Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.51%. Comparing base (5658d61) to head (ae3d213).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
crates/bitwarden-vault/src/cipher/ssh_key.rs 0.00% 5 Missing ⚠️
...s/bitwarden-vault/src/cipher/cipher_permissions.rs 0.00% 4 Missing ⚠️
crates/bitwarden-vault/src/cipher/cipher.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #434      +/-   ##
==========================================
- Coverage   76.53%   76.51%   -0.03%     
==========================================
  Files         269      270       +1     
  Lines       25312    25320       +8     
==========================================
  Hits        19373    19373              
- Misses       5939     5947       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gbubemismith gbubemismith requested review from nikwithak and removed request for shane-melton September 11, 2025 15:55
Copy link

@nikwithak nikwithak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@gbubemismith gbubemismith merged commit cb0ac94 into main Sep 11, 2025
50 checks passed
@gbubemismith gbubemismith deleted the vault/PM-25657 branch September 11, 2025 16:42
bw-ghapp bot pushed a commit to bitwarden/sdk-swift that referenced this pull request Sep 11, 2025
…ssing SSH key and permissions fields to cipher conversion (bitwarden/sdk-internal#434)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants