-
Notifications
You must be signed in to change notification settings - Fork 9
[PM-16908] Make WASM BitwardenClient API async #173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Great job, no security vulnerabilities found in this Pull Request |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #173 +/- ##
=======================================
Coverage 66.38% 66.38%
=======================================
Files 210 210
Lines 16136 16136
=======================================
Hits 10712 10712
Misses 5424 5424 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
# Conflicts: # crates/bitwarden-wasm-internal/build.sh
# Conflicts: # crates/bitwarden-wasm-internal/src/lib.rs
|
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-16908
📔 Objective
Created a script that marks any functions from
BitwardenClient
or it's subclients as async in the.d.ts
file. This is needed for the work in bitwarden/clients#13539, that exposes theBitwardenClient
API remotely through IPC.Note that the script also stores all the functions that return a subclient and saves that in the JS/TS files, for the client code to use it. This is because the clients will need to differenciate between functions that return subclients, and functions that actually need to call into the SDK.
As this is only applied to
BitwardenClient
and any subclients reachable from it, it won't affect separate clients likePureCrypto
I've created a separate temporary PR with some of the test functions I've used on the SDK here, including some subclients and callbacks: #174
⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes