CXF - Implement missing to view #429
Conversation
|
Great job! No new security vulnerabilities introduced in this pull request |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #429 +/- ##
==========================================
+ Coverage 76.52% 76.91% +0.38%
==========================================
Files 269 269
Lines 25312 25559 +247
==========================================
+ Hits 19371 19659 +288
+ Misses 5941 5900 -41 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
| }) | ||
| } | ||
| _ => None, | ||
| let (cipher_type, login, identity, card, secure_note, ssh_key) = match value.r#type { |
There was a problem hiding this comment.
Using so many optional values in a tuple is fairly noisy, I wonder if we're not better off just having mutable values:
let mut login = None;
let mut identity = None;
...
let cipher_type = match value.r#type {
CipherType::Login(l) => {
login = Some((*l).into());
bitwarden_vault::CipherType::Login
},
CipherType::Identity(l) => { ... }
}There was a problem hiding this comment.
It is, I do want us to rework the vault types though and I think the current structure aligns better with that then making it mutable?
🎟️ Tracking
📔 Objective
We discovered that any non login item were not imported correctly.
⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes