Skip to content

Conversation

aj-bw
Copy link
Member

@aj-bw aj-bw commented Sep 11, 2025

🎟️ Tracking

bre-1104

📔 Objective

related to #415 and #437
example failure after moving to oidc npm publish -> https://github.com/bitwarden/sdk-internal/actions/runs/17654697060/job/50174358624

it is searching for provenance information in the package.json file but the repository url is not defined there

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@aj-bw aj-bw requested a review from a team as a code owner September 11, 2025 19:18
@aj-bw aj-bw requested a review from coroiu September 11, 2025 19:18
Copy link
Contributor

github-actions bot commented Sep 11, 2025

Logo
Checkmarx One – Scan Summary & Detailsead33bf0-2cea-41de-a0ee-b80f3fc60775

Great job! No new security vulnerabilities introduced in this pull request

Copy link

Copy link

codecov bot commented Sep 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.93%. Comparing base (0b6d9c4) to head (be0b56b).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #438   +/-   ##
=======================================
  Coverage   76.93%   76.93%           
=======================================
  Files         270      270           
  Lines       25608    25608           
=======================================
  Hits        19702    19702           
  Misses       5906     5906           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aj-bw aj-bw enabled auto-merge (squash) September 11, 2025 19:53
@aj-bw aj-bw merged commit 1e3b4ba into main Sep 11, 2025
50 checks passed
@aj-bw aj-bw deleted the bre-1104/add-wasm-internal-package-json-repo-url branch September 11, 2025 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants