Skip to content

Conversation

mzieniukbw
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-24377

📔 Objective

Create a new SDK method in PureCrypto.decrypt_user_key_with_master_key.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@mzieniukbw mzieniukbw requested a review from a team as a code owner September 21, 2025 22:44
@mzieniukbw mzieniukbw requested review from dani-garcia, a team and Thomas-Avery and removed request for a team September 21, 2025 22:44
Copy link
Contributor

github-actions bot commented Sep 21, 2025

Logo
Checkmarx One – Scan Summary & Detailsf3c6343e-a90f-4035-8285-0c515fb5cf55

Great job! No new security vulnerabilities introduced in this pull request

Copy link

codecov bot commented Sep 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.18%. Comparing base (e30f1ea) to head (59df3cb).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #465      +/-   ##
==========================================
- Coverage   78.25%   78.18%   -0.07%     
==========================================
  Files         275      276       +1     
  Lines       27447    27508      +61     
==========================================
+ Hits        21479    21508      +29     
- Misses       5968     6000      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Hinton
Copy link
Member

Hinton commented Sep 22, 2025

@mzieniukbw ops, I accidentally pushed to the wrong branch 😓. I undid it, but hence the above force-push.

Copy link

Copy link
Member

@dani-garcia dani-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a small comment

Copy link
Contributor

@Thomas-Avery Thomas-Avery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants