-
Notifications
You must be signed in to change notification settings - Fork 20
[PM-24377] Adds decrypt_user_key_with_master_key
into PureCrypto
#465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Great job! No new security vulnerabilities introduced in this pull request |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #465 +/- ##
==========================================
- Coverage 78.25% 78.18% -0.07%
==========================================
Files 275 276 +1
Lines 27447 27508 +61
==========================================
+ Hits 21479 21508 +29
- Misses 5968 6000 +32 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@mzieniukbw ops, I accidentally pushed to the wrong branch 😓. I undid it, but hence the above force-push. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a small comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…decrypt_user_key_with_master_key` into PureCrypto (bitwarden/sdk-internal#465)
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-24377
📔 Objective
Create a new SDK method in
PureCrypto.decrypt_user_key_with_master_key
.⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes