- 
                Notifications
    You must be signed in to change notification settings 
- Fork 20
[deps]: Update rust Docker tag to v1.90 #531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| Internal tracking: 
 | 
| Claude finished @renovate[bot]'s task —— View job Review: Update Rust Docker tag to v1.90Summary of ChangesThis PR updates the Rust Docker base image in  Changed file:  Critical Issues🔴 Version Inconsistency with Project Requirements The project has explicit Rust version constraints that are inconsistent with this Docker image update: 
 This creates a significant version mismatch. The Dockerfile includes  Impact: While this won't break the build (rustup will install the correct version), it's wasteful and misleading: 
 Suggested Improvements1. Coordinate Rust Version Updates Across the Project Rather than updating the Docker image in isolation, Rust version updates should be coordinated across: 
 Consider one of these approaches: Option A: Keep Docker image aligned with rust-toolchain.tomlUpdate the Dockerfile to match the pinned toolchain version: FROM rust:1.87-alpine AS baseThis ensures consistency and avoids downloading an unnecessary Rust version. Option B: Update all Rust versions togetherIf the goal is to move to Rust 1.90, update all three files in a single coordinated PR: 
 This would require testing the entire codebase for compatibility with Rust 1.90. Option C: Use 'stable' instead of pinned versionsIf you want the Docker builds to automatically track stable Rust: FROM rust:alpine AS baseHowever, note that the  2. Consider Removing Redundant Base Image Version Since  FROM rust:alpine AS baseThis makes it clear that the toolchain file controls the actual Rust version used, not the base image. Good Practices Observed
 Action Items for Author
 RecommendationI recommend closing this PR and either: 
 The current change is harmless but provides no benefit and creates unnecessary confusion about which Rust version is actually being used. | 
| 
 Great job! No new security vulnerabilities introduced in this pull request | 
| Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. | 

This PR contains the following updates:
1.89-alpine->1.90-alpineConfiguration
📅 Schedule: Branch creation - "every 2nd week starting on the 2 week of the year before 4am on Monday" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.