Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SM-784: Enable Project Create/Edit/Delete CLI Commands #67

Merged
merged 14 commits into from
Jun 15, 2023
Merged

Conversation

coltonhurst
Copy link
Member

@coltonhurst coltonhurst commented Jun 9, 2023

Type of change

- [ ] Bug fix
- [x] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Based on SM-417 and this PR.

This PR adds the create, edit, and delete commands for projects to the bws cli.

Code changes

  • main.rs: Add CLI functionality for creating, editing, and deleting projects

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)

@coltonhurst coltonhurst self-assigned this Jun 9, 2023
@coltonhurst coltonhurst changed the title Enable Project Create/Edit/Delete CLI Commands SM-784: Enable Project Create/Edit/Delete CLI Commands Jun 9, 2023
@coltonhurst coltonhurst requested review from Hinton, dani-garcia and a team June 12, 2023 16:59
cd-bitwarden
cd-bitwarden previously approved these changes Jun 13, 2023
Copy link
Contributor

@cd-bitwarden cd-bitwarden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing job Colton! This looks really great 👍

Copy link
Member

@dani-garcia dani-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just two small changes

enum EditCommand {
#[clap(group = ArgGroup::new("edit_field").required(true).multiple(true))]
Project {
project_id: String,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you change this type to be Uuid here directly, you won't need to manually do Uuid::parse_str afterwards

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great point, updated!


#[derive(Subcommand, Debug)]
enum DeleteCommand {
Project { project_ids: Vec<String> },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same for this one

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great point, updated!

Base automatically changed from sm/SM-417 to master June 15, 2023 14:30
@coltonhurst coltonhurst dismissed cd-bitwarden’s stale review June 15, 2023 14:30

The base branch was changed.

@coltonhurst coltonhurst requested a review from dani-garcia June 15, 2023 14:52
Copy link
Member

@dani-garcia dani-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@coltonhurst coltonhurst merged commit 6758707 into master Jun 15, 2023
@coltonhurst coltonhurst deleted the sm/SM-784 branch June 15, 2023 15:32
@Hinton Hinton mentioned this pull request Jul 17, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants