-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SM-784: Enable Project Create/Edit/Delete CLI Commands #67
Conversation
…d changes from master
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing job Colton! This looks really great 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just two small changes
crates/bws/src/main.rs
Outdated
enum EditCommand { | ||
#[clap(group = ArgGroup::new("edit_field").required(true).multiple(true))] | ||
Project { | ||
project_id: String, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you change this type to be Uuid here directly, you won't need to manually do Uuid::parse_str afterwards
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great point, updated!
crates/bws/src/main.rs
Outdated
|
||
#[derive(Subcommand, Debug)] | ||
enum DeleteCommand { | ||
Project { project_ids: Vec<String> }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same for this one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great point, updated!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Type of change
Objective
Based on SM-417 and this PR.
This PR adds the create, edit, and delete commands for projects to the
bws
cli.Code changes
Before you submit