-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-3561] Clean the return url of any whitespace #3696
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3696 +/- ##
=========================================
+ Coverage 0 32.56% +32.56%
=========================================
Files 0 1213 +1213
Lines 0 63480 +63480
Branches 0 4780 +4780
=========================================
+ Hits 0 20674 +20674
- Misses 0 41843 +41843
- Partials 0 963 +963 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question about other whitespace encodings.
No New Or Fixed Issues Found |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Solid, but maybe throw in some tests.
a8da218
Type of change
Objective
Resolves potential security issues related to whitespace allowing open redirects with the SSO return URL.
Code changes
Before you submit
dotnet format --verify-no-changes
) (required)