[PM-8107] Remove Duo v2 from server

[ike-kottlowski]

🎟️ Tracking

PM-8107

Blocked By: #4894

📔 Objective

We are moving away from Duo Version 2 artifacts in our code. This aims to removes the last visages of Duo Version 2 from models, objects, and token providers.

A notable change is the Duo two-factor token, and organization token) have been renamed to better align with verbiage from Duo: name change to "Universal" instead of "web".

📸 Screenshots

Enable Duo / Disable - Show data validation and successful save (11/14/24 update)

msedge_MZYLgryruJ.mp4

Enabled Duo - Correct input validation -> Bad config error (Duo.Client.DoHealthCheck() fails) (11/14/24 update)

msedge_caLHcLAn8o.mp4

Login with Duo (11/14/24 update)

msedge_OaHc8O6bDM.mp4

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[codecov]

Codecov Report

Attention: Patch coverage is 85.10638% with 28 lines in your changes missing coverage. Please review.

Project coverage is 43.06%. Comparing base (6f7cdcf) to head (51a426a).
Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
...dentity/TokenProviders/DuoUniversalTokenService.cs	64.40%	19 Missing and 2 partials ⚠️
...Providers/OrganizationDuoUniversalTokenProvider.cs	93.61%	2 Missing and 1 partial ⚠️
.../Identity/TokenProviders/YubicoOtpTokenProvider.cs	0.00%	1 Missing and 1 partial ⚠️
.../Api/Auth/Models/Request/TwoFactorRequestModels.cs	90.00%	0 Missing and 1 partial ⚠️
...entity/TokenProviders/DuoUniversalTokenProvider.cs	98.03%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4934      +/-   ##
==========================================
+ Coverage   42.68%   43.06%   +0.38%     
==========================================
  Files        1406     1404       -2     
  Lines       65090    64713     -377     
  Branches     5969     5925      -44     
==========================================
+ Hits        27782    27869      +87     
+ Misses      36063    35610     -453     
+ Partials     1245     1234      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[JaredSnider-Bitwarden]

Really nice start on these changes! A bit more testing would be great!

[ike-kottlowski]

I've updated the description with current screen recordings.

@JaredSnider-Bitwarden