[PM-14275] Add IsManaged to OrganizationMetadata #4957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cturnbull-bitwarden
previously approved these changes
Oct 30, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4957 +/- ##
==========================================
+ Coverage 42.56% 42.57% +0.01%
==========================================
Files 1387 1387
Lines 64653 64645 -8
Branches 5936 5932 -4
==========================================
+ Hits 27521 27525 +4
+ Misses 35908 35898 -10
+ Partials 1224 1222 -2 ☔ View full report in Codecov by Sentry. |
cturnbull-bitwarden
previously approved these changes
Oct 31, 2024
jonashendrickx
previously approved these changes
Oct 31, 2024
amorask-bitwarden
dismissed stale reviews from jonashendrickx and cturnbull-bitwarden
via
3cb83db
cturnbull-bitwarden
previously approved these changes
Oct 31, 2024
jonashendrickx
approved these changes
Oct 31, 2024
amorask-bitwarden
deleted the
billing/PM-14275/resale-download-license
branch
amorask-bitwarden
added a commit
that referenced
this pull request
Oct 31, 2024
* Add IsManaged to OrganizationMetadata * Remove subscription requirement from self-host eligibility check * Remove unused service * Run dotnet format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-14275
📔 Objective
Organization owners managed by MSPs don't have access to Providers in the session state nor can they request full providers from the API because of permissions, but they need to know if they're managed so I'm returning it from Metadata.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes