[PM-13746] Remove loggedInUserId parameter. #5033
Open
+5
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. The calling code never passed in a loggedInUserId. \n2. Update/remove tests.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5033 +/- ##
==========================================
- Coverage 42.67% 42.67% -0.01%
==========================================
Files 1406 1406
Lines 65091 65075 -16
Branches 5969 5967 -2
==========================================
- Hits 27777 27770 -7
+ Misses 36070 36060 -10
- Partials 1244 1245 +1 ☔ View full report in Codecov by Sentry. |
|
No New Or Fixed Issues Found |
r-tome
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
Great work! Please link the ticket url in the PR description https://bitwarden.atlassian.net/browse/PM-13746
|
I'm reading through the process to see if it's safe to merge. |
I'm going to merge this in Tuesday after a new rc is cut. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-13746
📔 Objective
_organizationService.ValidateOrganizationUserUpdatePermissionssince it is not needed for updating group associations.loggedInUserIdsince it's no longer needed.📸 Screenshots
The unit test pretty much covers it, but here is a manual test for a sanity check.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes