Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BRE-101] Remove dept-devops from CODEOWNERS #35

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

michalchecinski
Copy link

๐ŸŽŸ๏ธ Tracking

https://bitwarden.atlassian.net/browse/BRE-101

๐Ÿšง Type of change

Remove dept-devops from all CODEOWNERS

  • ๐Ÿ› Bug fix
  • ๐Ÿš€ New feature development
  • ๐Ÿงน Tech debt (refactoring, code cleanup, dependency upgrades, etc.)
  • ๐Ÿค– Build/deploy pipeline (DevOps)
  • ๐ŸŽ‚ Other

๐Ÿ“” Objective

Remove dept-devops from all CODEOWNERS, and add dept-bre to .github/workflows/release.yml as owner.

๐Ÿ“‹ Code changes

  • .github/CODEOWNERS: Remove dept-devops from all CODEOWNERS, and add

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

@michalchecinski michalchecinski requested a review from a team as a code owner June 10, 2024 12:26
@michalchecinski
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants