Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repo tuneup #38

Merged
merged 2 commits into from
Jun 26, 2024
Merged

Repo tuneup #38

merged 2 commits into from
Jun 26, 2024

Conversation

withinfocus
Copy link
Contributor

@withinfocus withinfocus commented Jun 25, 2024

🎟️ Tracking

Internal change.

📔 Objective

Uses the latest template and adjusts the jobs a bit. There is planned work to decide between ACR and GHCR, but we can at least tweak a few things and use desired integrations.

As a result of the CR changes there is no deliberate extraction of build vs. test for now, and at a later date someone can apply the appropriate secret security (check run) in those workflows. Security scanning is also deferred until that time.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

codecov bot commented Jun 25, 2024

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@withinfocus withinfocus marked this pull request as ready for review June 25, 2024 14:11
@withinfocus withinfocus requested review from a team as code owners June 25, 2024 14:11
Copy link
Member

@coltonhurst coltonhurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some general questions, there may be DevOps decisions for this I'm not aware of.

.github/workflows/build-ghcr.yml Show resolved Hide resolved
.github/workflows/bump-version.yml Show resolved Hide resolved
.github/workflows/workflow-linter.yml Show resolved Hide resolved
@withinfocus withinfocus merged commit 92fa608 into main Jun 26, 2024
4 checks passed
@withinfocus withinfocus deleted the tuneup branch June 26, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants