Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sjcl.bn.power
will no longer freeze if it's not in a field andsjcl.bn.powermod
is slightly faster.bn.montpowermod(x, N)
, andbn.powermod(x, N)
defers to it when possible (when the modulus is odd).Here are some very rough benchmarks I took from my iMac and Ubuntu laptop: (All using 32 byte secret keys, running the code sample from the top of issue #172)
Chrome is usually a tick faster than Firefox. It'd be great if someone else can vouch for similar speeds.
Supersedes pull request #203 and hopefully resolves issue #172.
Questions:
bn.*mod(..., N)
methods)? How should the modulus be passed in?