Update pbkdf2.js #421
Open
Update pbkdf2.js #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please add hash param as suggested in the change. There is no way of using anything except SHA256, since this is a default in HMAC. That creates issues for keys derived by other systems that use a different hash function.
… what was wrong. The current implementation causes PKCS#5 verification failure in cbc.js
…re new and old implementations of 'equal'
I've created more changes related to bitArray.equal function, which currently has a bug causing PKCS5 validation failure in cbc.js. 'equal' functiom should exclude bitts following partial since they are not a part of bitArray. I've also added test case for 'equal' to bitArray_test.js file.
|
Hey |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please add hash param as suggested in the change. There is no way of using anything except SHA256, since this is a default in HMAC. That creates issues for keys derived by other systems that use a different hash function.
I've just committed yet another change to the same "pull" location: https://github.com/ogryb/sjcl.git
Please take a look. A bug in bitArray.equal function causes PKCS5 verification failure in cbc.js, so it needs to be fixed. We should exclude the bits following partial, since they are not really a part of the bit array.