Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How is storing the shared secret password safe? #263

Closed
San-Jeevan opened this issue Sep 2, 2017 · 2 comments
Closed

How is storing the shared secret password safe? #263

San-Jeevan opened this issue Sep 2, 2017 · 2 comments

Comments

@San-Jeevan
Copy link

San-Jeevan commented Sep 2, 2017

The new version of this component requires shared apple password as input parameter to verify receipt. If someone reverse engineer the binary they can retrieve the password and use it for malicious purposes!!

the shared secret is supposed to be used on own server for verifying receipts

@bizz84
Copy link
Owner

bizz84 commented Sep 3, 2017

@San-Jeevan SwiftyStoreKit simply provides a way to send the shared secret to the Apple endpoints (https://buy.itunes.apple.com/verifyReceipt and https://sandbox.itunes.apple.com/verifyReceipt) when verifying the receipt.

This is done in the AppleReceiptValidator class, which is simply a reference implementation for how to do receipt validation with Apple.

Sounds like I should clarify this in the README so that users are aware of any security implications and quote any recommendations by Apple on this matter.

@bizz84
Copy link
Owner

bizz84 commented Oct 12, 2017

With the latest changes on develop, the shared secret is now used only by AppeReceiptValidator, which is a reference implementation.

I'm closing this as the README now better explains the security considerations around this.

Feel free to reopen if you feel the documentation could be improved further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants