Enabled InAppReceiptRefreshRequest for macOS as it is supported

[einsteinx2]

• Also productIdentifier is not optional on macOS with Swift 3 so I removed that workaround code

[bizz84]

Thanks for the PR!

I've been testing this and I observed the following when refreshing the receipt on macOS:

<NSXPCConnection: 0x600000102640> connection to service named com.apple.storeagent.storekit: Warning: Exception caught during decoding of received reply to message 'requestVPPReceiptRenewalWithSandboxOptions:replyBlock:', dropping incoming message and calling failure block.

As a result, I get the following callback in InAppReceiptRefreshRequest:

func request(_ request: SKRequest, didFailWithError error: Error)

Strangely though, it appears that the .success case is executed in the completion block in SwiftyStoreKit.refreshReceipt():

            switch result {
            case .success:
                if let appStoreReceiptData = InAppReceipt.appStoreReceiptData {
                    completion(.success(receiptData: appStoreReceiptData))
                }
                else {
                    completion(.error(error: ReceiptError.noReceiptData))
                }
            case .error(let e):
                completion(.error(error: e))
            }

This is not the case on iOS where I get the .error(let e) case instead.

I was wondering if you have observed a similar behaviour?

[einsteinx2]

Weird, no I'm not seeing that. I just double checked again to be sure.