Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support swift 5 #457

Merged
merged 3 commits into from
Apr 30, 2019
Merged

support swift 5 #457

merged 3 commits into from
Apr 30, 2019

Conversation

0ber
Copy link
Contributor

@0ber 0ber commented Mar 27, 2019

Converted the SwiftyStoreKit-iOS to swift 5

@0ber 0ber changed the base branch from master to develop March 27, 2019 13:16
@OdNairy
Copy link

OdNairy commented Apr 5, 2019

You also need change osx_image in .travis.yml from xcode10 to xcode10.2 to use Xcode 10.2.

Reference: https://docs.travis-ci.com/user/reference/osx/

@0ber
Copy link
Contributor Author

0ber commented Apr 8, 2019

change osx_image in .travis.yml from xcode10 to xcode10.2

done

@bizz84
Copy link
Owner

bizz84 commented Apr 8, 2019

1 Warning
⚠️ No CHANGELOG changes made

Generated by 🚫 Danger

@AndrewBennet
Copy link

AndrewBennet commented Apr 12, 2019

Any chance this could get merged in and released? Would be nice to be rid of the build warnings in Xcode 10.2

@0ber
Copy link
Contributor Author

0ber commented Apr 15, 2019

@@ -78,6 +78,7 @@ extension SKPaymentTransactionState: CustomDebugStringConvertible {
case .failed: return "failed"
case .restored: return "restored"
case .deferred: return "deferred"
@unknown default: return "default"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally I think this would be better as unknown?

Suggested change
@unknown default: return "default"
@unknown default: return "unknown"

@bizz84 bizz84 merged commit 6d1a7e5 into bizz84:develop Apr 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants