Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing arguments, use typehint #162

Merged
merged 15 commits into from
Jun 18, 2024
+103 −130
Merged

Fix parsing arguments, use typehint #162

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
3694592
fixing some tests
bjartek May 21, 2024
3425ab4
simplified a bit
bjartek May 21, 2024
36d941f
try to incorporate new underflow
bjartek May 22, 2024
5fac824
remove dead code
bjartek May 22, 2024
a9c2b37
fixed errors and made sure tests pass
bjartek May 22, 2024
b50e51a
removed tests we do not need
bjartek May 22, 2024
1133923
use release of underflow
bjartek Jun 14, 2024
3107f98
tidy
bjartek Jun 14, 2024
5629e99
fixed multierr
bjartek Jun 14, 2024
3442665
tidy
bjartek Jun 14, 2024
8c4e554
simplify code and provide better error message
bjartek Jun 14, 2024
0d38c9c
add deprecation
bjartek Jun 14, 2024
9bb480f
remove uneeded test
bjartek Jun 14, 2024
af6b351
fix some lint errors
bjartek Jun 18, 2024
8c7fbc2
try to update github actions
bjartek Jun 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Loading
Loading status checks…
try to update github actions
@bjartek
bjartek committed Jun 18, 2024
commit 8c7fbc277aad571ce3eb4b44a5e550f1ba70ae46
28 changes: 14 additions & 14 deletions .github/workflows/ci.yaml
View file
Original file line number Diff line number Diff line change
@@ -12,35 +12,35 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout code
uses: actions/checkout@v3
- uses: actions/setup-go@v4
uses: actions/checkout@v4
- uses: actions/setup-go@v5
with:
go-version: "1.21.*"
go-version: "1.22.*"
- name: golangci-lint
uses: golangci/golangci-lint-action@v2
uses: golangci/golangci-lint-action@v6
with:
args: --timeout=3m

tidy:
runs-on: ubuntu-latest
steps:
- name: Checkout code
uses: actions/checkout@v3
- uses: actions/setup-go@v4
uses: actions/checkout@v4
- uses: actions/setup-go@v5
with:
go-version: "1.21.*"
go-version: "1.22.*"
- uses: zencargo/github-action-go-mod-tidy@v1
with:
go-version: "1.21"
go-version: "1.22"

test:
runs-on: ubuntu-latest
steps:
- name: Checkout code
uses: actions/checkout@v3
- uses: actions/setup-go@v4
uses: actions/checkout@v4
- uses: actions/setup-go@v5
with:
go-version: "1.21"
go-version: "1.22"
- run: make test-report
- name: Publish Unit Test Results
uses: EnricoMi/publish-unit-test-result-action@v1
@@ -52,10 +52,10 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout code
uses: actions/checkout@v3
- uses: actions/setup-go@v4
uses: actions/checkout@v4
- uses: actions/setup-go@v5
with:
go-version: "1.21"
go-version: "1.22"
- run: make coveralls
- uses: shogo82148/actions-goveralls@v1
if: always()

Unchanged files with check annotations Beta

View file
event.go
"strings"
"testing"
"github.com/bjartek/underflow"

Check failure on line 9 in event.go

GitHub Actions / lint 

import 'github.com/bjartek/underflow' is not allowed from list 'Main' (depguard)
"github.com/onflow/cadence"

Check failure on line 10 in event.go

GitHub Actions / lint 

import 'github.com/onflow/cadence' is not allowed from list 'Main' (depguard)
"github.com/onflow/flow-go-sdk"

Check failure on line 11 in event.go

GitHub Actions / lint 

import 'github.com/onflow/flow-go-sdk' is not allowed from list 'Main' (depguard)
"github.com/sanity-io/litter"

Check failure on line 12 in event.go

GitHub Actions / lint 

import 'github.com/sanity-io/litter' is not allowed from list 'Main' (depguard)
"golang.org/x/exp/slices"
)
View file
interaction_builder.go
"strings"
"testing"
"github.com/bjartek/underflow"

Check failure on line 11 in interaction_builder.go

GitHub Actions / lint 

import 'github.com/bjartek/underflow' is not allowed from list 'Main' (depguard)
"github.com/enescakir/emoji"

Check failure on line 12 in interaction_builder.go

GitHub Actions / lint 

import 'github.com/enescakir/emoji' is not allowed from list 'Main' (depguard)
"github.com/onflow/cadence"

Check failure on line 13 in interaction_builder.go

GitHub Actions / lint 

import 'github.com/onflow/cadence' is not allowed from list 'Main' (depguard)
"github.com/onflow/flow-go-sdk"

Check failure on line 14 in interaction_builder.go

GitHub Actions / lint 

import 'github.com/onflow/flow-go-sdk' is not allowed from list 'Main' (depguard)
"github.com/onflow/flowkit/v2"

Check failure on line 15 in interaction_builder.go

GitHub Actions / lint 

import 'github.com/onflow/flowkit/v2' is not allowed from list 'Main' (depguard)
"github.com/onflow/flowkit/v2/accounts"

Check failure on line 16 in interaction_builder.go

GitHub Actions / lint 

import 'github.com/onflow/flowkit/v2/accounts' is not allowed from list 'Main' (depguard)
"github.com/onflow/flowkit/v2/transactions"
"github.com/pkg/errors"
)