remove CopyStmt::Unknown

bjjwwang · Mar 15, 2024 · 70a7b9b · 70a7b9b
1 parent 81f2d76
commit 70a7b9b
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 10 deletions.
diff --git a/svf-llvm/include/SVF-LLVM/SVFIRBuilder.h b/svf-llvm/include/SVF-LLVM/SVFIRBuilder.h
@@ -401,7 +401,7 @@ class SVFIRBuilder: public llvm::InstVisitor<SVFIRBuilder>
                     return CopyStmt::COPYVAL;
             }
         }
-        return CopyStmt::UNKNOWN;
+        assert (false && "Unknown cast inst!");
     }
 
     /// Add Copy edge

diff --git a/svf-llvm/lib/LLVMModule.cpp b/svf-llvm/lib/LLVMModule.cpp
@@ -1271,10 +1271,11 @@ SVFConstantData* LLVMModuleSet::getSVFConstantData(const ConstantData* cd)
                     dval =  cfp->getValueAPF().convertToDouble();
                 }
                 else {
-
+                    assert (false && "Unsupported floating point type");
                 }
             } else {
-
+                // other cfp type, like isZero(), isInfinity(), isNegative(), etc.
+                // do nothing
             }
             svfcd = new SVFConstantFP(getSVFType(cd->getType()), dval);
         }

diff --git a/svf/include/SVFIR/SVFStatements.h b/svf/include/SVFIR/SVFStatements.h
@@ -372,7 +372,7 @@ class CopyStmt: public AssignStmt
     void operator=(const CopyStmt&); ///< place holder
 public:
     enum CopyKind {COPYVAL, ZEXT, SEXT, BITCAST, TRUNC, FPTRUNC,
-         FPTOUI, FPTOSI, UITOFP, SITOFP, INTTOPTR, PTRTOINT, UNKNOWN};
+         FPTOUI, FPTOSI, UITOFP, SITOFP, INTTOPTR, PTRTOINT};
     /// Methods for support type inquiry through isa, cast, and dyn_cast:
     //@{
     static inline bool classof(const CopyStmt*)

diff --git a/svf/lib/AE/Svfexe/SVFIR2ItvExeState.cpp b/svf/lib/AE/Svfexe/SVFIR2ItvExeState.cpp
@@ -959,7 +959,9 @@ void SVFIR2ItvExeState::translateCopy(const CopyStmt *copy)
     {
         if (inVarToValTable(rhs))
         {
-            _es[lhs] = _es[rhs];
+            if (copy->getCopyKind() == CopyStmt::COPYVAL) {
+                _es[lhs] = _es[rhs];
+            }
             if (copy->getCopyKind() == CopyStmt::ZEXT) {
                 _es[lhs] = getZExtValue(copy->getRHSVar());
             }
@@ -984,8 +986,6 @@ void SVFIR2ItvExeState::translateCopy(const CopyStmt *copy)
             else if (copy->getCopyKind() == CopyStmt::FPTRUNC) {
                 _es[lhs] = getFPTruncValue(copy->getRHSVar(), copy->getLHSVar()->getType());
             }
-
-
         }
         else if (inVarToAddrsTable(rhs))
         {

diff --git a/svf/lib/SVFIR/PAGBuilderFromFile.cpp b/svf/lib/SVFIR/PAGBuilderFromFile.cpp
@@ -202,9 +202,6 @@ void PAGBuilderFromFile::addEdge(NodeID srcID, NodeID dstID,
         else if (opType == "PTRTOINT") {
             pag->addCopyStmt(srcID, dstID, CopyStmt::PTRTOINT);
         }
-        else if (opType == "UNKNOWN") {
-            pag->addCopyStmt(srcID, dstID, CopyStmt::UNKNOWN);
-        }
         else {
             assert(false && "format not support, can not create such edge");
         }