Avoid dependency resolution at configuration time + only depend on compileUnitTest tasks #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 28, 2019 11:03
Previously, the "unmock" configuration was resolved and the robolectric dependency was downloaded at Gradle configuration time, which would happen for ANY Gradle invocation rather than only when the unmock task was being run. With this change, the default robolectric jar is specified using Gradle's default dependency API so we don't need to manually check the size of the configuration and add it. We also pass the configuration FileCollection to the task instead of passing the resolved file, which lets resolution happen at task execution time. Using the FileCollection#getSingleFile() API also gives a much nicer error message if the user tries to add multiple dependencies to the "unmock" configuration. Previously we said to do a clean build or clear Gradle caches, which wouldn't have actually fixed the problem. Now the error (which comes from Gradle) explicitly says that there should only be one dependency added to the "unmock" configuration.
Previously the unmock tasks were added to every "compile" task, which meant it would run even when compiling non-test source code. Now it will only depend on the tasks that compile JVM unit test code, not production code or androidTest code. We could potentially do even better and depend on the specific tasks that compile JVM unit tests by depending on AGP and getting a reference to the tasks explicitly instead of with a regex. Depending on AGP, however, is kind of painful for consumers though, since we would need unmock to update AGP in a timely manner when new versions are released.
Merged
bjoernQ
approved these changes
Feb 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.