-
-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drawing, config, callbacks: add arrowtype option allowing arrow heads… #195
Conversation
… at both line ends re bk138#67
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, sorry for the long delay, I got held back by other stuff. Also again, thanks for that nice contribution, I have only some minor change requests.
PS: Don't bother keeping a clean history on the branch, I'll simply squash-merge when ready.
Thanks again!
0d0409b
to
dc1d60f
Compare
I updated the PR accordingly, now writing the value in the enum as
which should be clear... |
dc1d60f
to
110d6e6
Compare
110d6e6
to
315496d
Compare
Yeah this is even more clear, thanks! |
One more thing: I noticed that the following minimal config
does not correctly parse arrowtype. |
d78ac89
to
737cbc2
Compare
Indeed parsing arrowsize did reset the option to arrowtype=="end", so arrowtype only worked as intended after arrowsize. Also, I removed ARROW_TYPE_NONE because it was redundant with arrowsize==0. Anyway, arrowsize==0 acts as flag whether there are arrows, and only then is the arrow type tested. |
737cbc2
to
f311668
Compare
… at both line ends
Syntax in config file with new option
arrowtype
, which can take values"->"
(default),"<-"
, or "<->
".Example: