add error log detecting uint8_t overflow in hlsl shader compilation #3226
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error looks like following:
![image](https://private-user-images.githubusercontent.com/40307536/291704084-da7d2bf7-bc50-40ed-a077-c403eeff4c7f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkxOTg2NzIsIm5iZiI6MTczOTE5ODM3MiwicGF0aCI6Ii80MDMwNzUzNi8yOTE3MDQwODQtZGE3ZDJiZjctYmM1MC00MGVkLWEwNzctYzQwM2VlZmY0YzdmLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEwVDE0MzkzMlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWVlMWZlNjEyZjgzOTZiYTkxNzkzZDUzZDg4NTM2ZDk4ZjM5NGI3ZWQ3MGJkNThiNzc2MGE1MmQ5YTA3MTRjMjcmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.BVj2CDLqSE7rvZ0O7H2knGEgXbj9Wf4mZh7ODRpAPAQ)
I ran into this because I tried to make a shader with a uniform array of over 255 elements. Finding the problem was kind of tricky.. had to back track to where the shader was being deserialized. This error would have helped.