Fixes for cubemap loading from ktx/pvr3 container #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goodartistscopy
added a commit
to goodartistscopy/bimg
that referenced
this pull request
Oct 26, 2021
Change was introduced by commit bkaradzic#63 (b8a7a90)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ktx: imageSize checking is modified to conform to cubemap exception rule.
https://www.khronos.org/registry/KTX/specs/1.0/ktxspec_v1.html#2.16
This fired the assert: BX_ASSERT(size == imageSize, "KTX: Image size mismatch %d (expected %d).", size, imageSize);
(To reproduce with texturev I had to enable assert because it was defined as NOOP in debug msvc project)
pvr3: container surface layout is similar to ktx (mip first then array/cubemap faces)
See section 4 in http://cdn.imgtec.com/sdk-documentation/PVR+File+Format.Specification.pdf
Here are two files (ktx and a pvr) that reproduce the issue:
cubemaps.zip