Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 1.2.x changes behaviour #26

Closed
vmx opened this issue Nov 7, 2022 · 2 comments · Fixed by #31
Closed

Version 1.2.x changes behaviour #26

vmx opened this issue Nov 7, 2022 · 2 comments · Fixed by #31

Comments

@vmx
Copy link

vmx commented Nov 7, 2022

I've a problem with upgrading from 1.1.3 to version 1.2.1. Here are the steps to reproduce the problem.

git clone https://github.com/multiformats/rust-multihash.git --branch v0.16.3
cd rust-multihash
cargo build
cargo update --package proc-macro-crate
cargo build

The build fails, due to crate_name() returning Ok(FoundCrate::Name("multihash")) instead of Ok(FoundCrate::Itself) (https://github.com/multiformats/rust-multihash/blob/v0.16.3/derive/src/utils.rs#L8-L11).

You can see the difference in the output via cargo expand multihash_impl.

@vmx vmx changed the title Version 1.2.x changes behavious Version 1.2.x changes behaviour Nov 7, 2022
@bkchr bkchr closed this as completed in #31 Jan 24, 2023
@vmx
Copy link
Author

vmx commented Jan 24, 2023

Thanks a lot for the fix, it fixes my issue!

@bkchr
Copy link
Owner

bkchr commented Jan 24, 2023

NP! I tested it with your repo :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants