Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update Cargo.lock #244

Merged
merged 1 commit into from
Nov 7, 2022
Merged

chore: update Cargo.lock #244

merged 1 commit into from
Nov 7, 2022

Conversation

vmx
Copy link
Member

@vmx vmx commented Nov 7, 2022

parity-scale-codec and cpufeatures referred in the Cargo.lock file were pointing to yanked versions. Hence update.

@vmx vmx requested review from Stebalien and mriise November 7, 2022 13:53
@Stebalien
Copy link
Member

CI seems very sad, but I'm not sure why...

`parity-scale-codec` and `cpufeatures` referred in the Cargo.lock file
were pointing to yanked versions. Hence update.

The `proc-macro-crate` crate needs to be restricted to 1.1.x as version
1.2.x returns `multihash` instead of `Itself` in some cases.
@vmx vmx force-pushed the update-cargo-lock-20221107 branch from 417d0d5 to 434d2a3 Compare November 7, 2022 14:48
@vmx
Copy link
Member Author

vmx commented Nov 7, 2022

CI is unhappy due to bkchr/proc-macro-crate#26 :( I've restricted proc_macro_crate to the good version for now.

@vmx
Copy link
Member Author

vmx commented Nov 7, 2022

The Nix build is failing, I think it's due to using an arbitrary nightly version. Do we care? (I know too little about Nix to fix it).

@Stebalien
Copy link
Member

Oh, I see. It looks like we're using a somewhat non-standard flow so I'm not sure what the right fix is. Nix looks even more complicated than Debian, and that's saying something.

Let's merge but file an issue...

@Stebalien Stebalien merged commit d27aa77 into master Nov 7, 2022
@vmx vmx deleted the update-cargo-lock-20221107 branch November 7, 2022 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants