Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually implement Display/Error for Error #27

Merged
merged 1 commit into from
Dec 15, 2022

Conversation

coolreader18
Copy link
Contributor

This improves build times for crates that depend on this crate, since instead of making a chain in the build graph like this:

  • foo-macro
    • syn
    • proc-macro-crate
      • thiserror
        • syn

Which forces syn to be built in series (syn then proc-macro-crate then foo-macro), it instead can look like

  • foo-macro
    • syn
    • proc-macro-crate

Which lets it build in parallel (syn AND proc-macro-crate, then foo-macro).

@bkchr bkchr merged commit fb8a49a into bkchr:master Dec 15, 2022
@coolreader18 coolreader18 deleted the manual-error branch December 19, 2022 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants