New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Also allow Duration argument to parse "infinity" #322

Merged

bkirwi merged 1 commit into bkirwi:master from mdedetrich:allow-infinity-for-finite-duration

Jul 23, 2021

Contributor

mdedetrich commented Jul 19, 2021

This PR allows the ability to parse "infinity" as a valid value for Duration. The primary reason for doing this change is that I noticed that akka libraries use "infinity" as a string value to designate Duration.Inf (i.e. https://github.com/akka/alpakka-kafka/blob/eb5246d3e03992ce60a1f33fefe75dadc58bc866/core/src/main/scala/akka/kafka/internal/ConfigSettings.scala#L44-L47)


          Also allow Duration argument to parse "infinity"

4723f10

bkirwi merged commit b2fba4e into bkirwi:master

Owner

bkirwi commented Jul 23, 2021

Shouldn't hurt!

mdedetrich deleted the allow-infinity-for-finite-duration branch

July 23, 2021 23:00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet