Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable coretime on Kusama #3

Merged
merged 5 commits into from
Feb 24, 2024
Merged

Enable coretime on Kusama #3

merged 5 commits into from
Feb 24, 2024

Conversation

eskimor
Copy link

@eskimor eskimor commented Feb 23, 2024 •
edited
Loading

  • Add on-demand
  • Replace assignment provider with coretime assignment provider
  • Add migrations to port initial configuration and also send it to the coretime chain.

bkchr
bkchr approved these changes Feb 24, 2024
View reviewed changes
Copy link

@bkchr bkchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bkontur can you merge this to your branch please?

@bkontur bkontur merged commit 1bbbe73 into bkontur:bko-bump-to-1.6 Feb 24, 2024
27 checks passed
bkontur
bkontur reviewed Feb 24, 2024
View reviewed changes
relay/kusama/src/lib.rs
@@ -1613,14 +1640,15 @@ construct_runtime! {
ParaSessionInfo: parachains_session_info = 61,
ParasDisputes: parachains_disputes = 62,
ParasSlashing: parachains_slashing = 63,
// TODO:(PR#159)(PR#1694): check rename `ParachainsAssignmentProvider` and remove `Storage` bellow and remove this comment!
ParachainsAssignmentProvider: parachains_assigner_parachains = 64,
OnDemandAssignmentProvider: parachains_assigner_on_demand = 64,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eskimor @bkchr
merged, just a dumb question, doesn't this name change for the 64 index affect any storage key or whatever?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ParachainsAssignmentProvider had no calls. So, this doesn't change anything.

@bkontur bkontur mentioned this pull request Feb 24, 2024
Merged
11 tasks
@bkontur
Copy link
Owner

bkontur commented Feb 24, 2024

@bkontur can you merge this to your branch please?

cool, thank you, merged

bkchr pushed a commit to polkadot-fellows/runtimes that referenced this pull request Feb 27, 2024
@bkontur @joepetrowski
@franciscoaguirre @brenzi @acatangiu @fellowship-merge-bot
Upgrade to latest polkadot-sdk@1.6 release (#159)
59172d5 
Based on bump to
[`polkadot-sdk@1.5.0`](#137).

Attached result of `cargo upgrade -v --pinned --incompatible`
[cargo-upgrade-version-bump.log](https://github.com/polkadot-fellows/runtimes/files/14044160/cargo-upgrade-version-bump.log)

_Note: Encointer was not upgraded (because its pallet references
`polkadot@1.3.0` release)._

## ~~For reviewers~~

~~This PR is against `polkadot-fellows`'s main to bring it to the
fellows repo, but if you want to see a real diff relevant to the
`polkadot-sdk@1.6.0` update please check:
bkontur/runtimes@bko-bump-to-1.5...bkontur:runtimes:bko-bump-to-1.6.~~


## TODO

- [x] fix compilation
- [x] fix integration tests
- [x] fix benchmarks (also try them) - `collectives-polkadot` `payout`
- [ ] ~~Does not require a CHANGELOG entry~~
- [x] `warning: use of deprecated struct
`staging_xcm_builder::CurrencyAdapter`: Use `FungibleAdapter` instead`
- [ ] search for `TODO:(PR#159) change to FungibleAdapter` and/or wait
for paritytech/polkadot-sdk#3287
- [x] patch for `pallet-nomination-pools` migration fix
paritytech/polkadot-sdk#3093
- will be fixed here
#188 (comment)
- [x] patch for `xcm-executor` fix (for 1.6.0) e.g.
paritytech/polkadot-sdk#3174
- [x] check/fix coretime stuff for Kusama/Polkadot - search for `//
TODO:(PR#159)(PR#1694)` - see
[comment](#159 (comment))
- fixed by bkontur#3
- [x] check the
`MaxControllersInDeprecationBatch`https://github.com/polkadot-fellows/runtimes/pull/159/files#r1492361038
- [x] check `pallet_identity::Config` for Kusama and Polkadot
https://github.com/polkadot-fellows/runtimes/pull/159/files#r1492363866

---------

Signed-off-by: Adrian Catangiu <adrian@parity.io>
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>
Co-authored-by: Francisco Aguirre <franciscoaguirreperez@gmail.com>
Co-authored-by: Ross Bulat <ross@parity.io>
Co-authored-by: Alain Brenzikofer <alain@integritee.network>
Co-authored-by: eskimor <eskimor@no-such-url.com>
Co-authored-by: Adrian Catangiu <adrian@parity.io>
Co-authored-by: fellowship-merge-bot[bot] <151052383+fellowship-merge-bot[bot]@users.noreply.github.com>
bkontur pushed a commit that referenced this pull request Mar 20, 2024
@claravanstaden
Merge pull request #3 from bkontur/bko-snowbridge-nits
c88230e 
Nits for Snowbridge + stuff moving around
bkontur pushed a commit that referenced this pull request Jun 7, 2024
@joepetrowski
Merge pull request #3 from bkontur/polkadot-people
253ce14 
Weights for `polkadot_runtime_common::identity_migrator`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkontur bkontur bkontur left review comments

@bkchr bkchr bkchr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eskimor @bkontur @bkchr